Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Visible Time Range UI issue where the summary string would display the wrong data range #5034

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Feb 5, 2024

What

The "Override" settings were summarised even when the feature was set to "Default".

image

This PR fixes the summary line to display the summary for the default value when those apply.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface include in changelog labels Feb 5, 2024
@teh-cmc teh-cmc self-requested a review February 6, 2024 07:49
@teh-cmc teh-cmc merged commit bca6603 into main Feb 6, 2024
43 of 44 checks passed
@teh-cmc teh-cmc deleted the antoine/fix-vh-display-bug branch February 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants