Skip to content

Commit

Permalink
Fix a Visible Time Range UI issue where the summary string would disp…
Browse files Browse the repository at this point in the history
…lay the wrong data range (#5034)

### What

The "Override" settings were summarised even when the feature was set to
"Default".


![image](https://github.com/rerun-io/rerun/assets/49431240/c9482fa5-cab7-425e-a970-2275f0a1f30f)

This PR fixes the summary line to display the summary for the default
value when those apply.
  • Loading branch information
abey79 authored Feb 6, 2024
1 parent 6140c7c commit bca6603
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions crates/re_viewer/src/ui/visible_history.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ pub fn visible_history_ui(
)
})
.inner;

current_range_ui(ctx, ui, current_time, is_sequence_timeline, visible_history);
} else {
resolved_visible_history_boundary_ui(
ctx,
Expand All @@ -181,16 +183,23 @@ pub fn visible_history_ui(
is_sequence_timeline,
true,
);

resolved_visible_history_boundary_ui(
ctx,
ui,
&resolved_visible_history.to,
is_sequence_timeline,
false,
);
}

current_range_ui(ctx, ui, current_time, is_sequence_timeline, visible_history);
current_range_ui(
ctx,
ui,
current_time,
is_sequence_timeline,
resolved_visible_history,
);
}

ui.add(
egui::Label::new(
Expand Down

0 comments on commit bca6603

Please sign in to comment.