Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalar's default visible range prints incorrect range #4986

Closed
Wumpf opened this issue Jan 31, 2024 · 3 comments · Fixed by #5066
Closed

scalar's default visible range prints incorrect range #4986

Wumpf opened this issue Jan 31, 2024 · 3 comments · Fixed by #5066
Assignees
@jleibs
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Milestone
0.13

Comments

@Wumpf
Copy link
Member

Wumpf commented Jan 31, 2024 •
edited
Loading

Looking at the sin/cos lines in the plots example.
The space view says:
image

But clicking on one of the lines it claims there's thing visible:
image
Also the greyed text is incorrect? This applies only to this one now
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Jan 31, 2024
@Wumpf Wumpf added this to the 0.13 milestone Jan 31, 2024
@abey79
Copy link
Member

abey79 commented Feb 6, 2024

#5034 did not fix that 🤔

@abey79
Copy link
Member

abey79 commented Feb 6, 2024 •
edited
Loading

I believe this is not a UI bug strictly speaking. The accumulated entity properties seem to be erroneous for those entities.

cc @jleibs

@abey79
Copy link
Member

abey79 commented Feb 6, 2024

Also the greyed text is incorrect? This applies only to this one now

Is that true? I didn't think so.

@jleibs jleibs mentioned this issue Feb 6, 2024
Merged
5 tasks
@jleibs jleibs self-assigned this Feb 6, 2024
jleibs added a commit that referenced this issue Feb 6, 2024
@jleibs
Propagate visible history default values correctly (#5066)
4827642 
### What
 - Resolves: #4986

Reduces the number of places where we duplicate the default code by
using `root_data_result` as the seed for the overrides.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5066/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5066/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5066/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5066)
- [Docs
preview](https://rerun.io/preview/b1b9c962e9377d72689ad8798e64ad7015210058/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b1b9c962e9377d72689ad8798e64ad7015210058/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Propagate visible history default values correctly rerun-io/rerun
3 participants
@Wumpf @jleibs @abey79