Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisconnectedSpace now only applies to spatial space views #4935

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 29, 2024

What

This PR only addresses the documentation. main is actually in a slightly mixed state right now: Visualizability is already determined strictly with DisconnectedSpace only applying to spatial views, but we still have the legacy SpaceInfo used in some places that applies this concept to everything. This will be removed in a a follow-up.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation 🍏 primitives Relating to Rerun primitives include in changelog labels Jan 29, 2024
@Wumpf Wumpf mentioned this pull request Jan 29, 2024
4 tasks
@Wumpf Wumpf merged commit 2b3e31b into main Jan 30, 2024
43 checks passed
@Wumpf Wumpf deleted the andreas/disconnected-space-for-spatial-only branch January 30, 2024 12:07
Wumpf added a commit that referenced this pull request Jan 30, 2024
### What

* Fixes #4388
   * this is the last piece 🥳  
* Related to
   * #4935
   * #4826

`SpaceInfo` used to be used to determine space connectivity, this is by
now done by `SpatialTopology`

Not a "pure" refactor: Slight changes in behavior
* Adding a space view via the 'plus' top left uses the default-created
list, not the now removed "all" list (which was poorly defined)
* Similarly, suggestions for root now use the default-created list
* adding entities via the add-ui no longer uses any kind of transform
analysis (it relied on SpaceInfo)
   * Does not fix  #4826
* .. since it still won't allow adding things that aren't visualizable
at all



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4937/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4937/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4937/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4937)
- [Docs
preview](https://rerun.io/preview/d27d81f094e026a2cecfd42ac25dc133d9ed26f6/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/d27d81f094e026a2cecfd42ac25dc133d9ed26f6/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog 🍏 primitives Relating to Rerun primitives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisconnectSpace and TimeSeriesScalar
3 participants