Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy SpaceInfo #4937

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Remove legacy SpaceInfo #4937

merged 4 commits into from
Jan 30, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 29, 2024

What

SpaceInfo used to be used to determine space connectivity, this is by now done by SpatialTopology

Not a "pure" refactor: Slight changes in behavior

  • Adding a space view via the 'plus' top left uses the default-created list, not the now removed "all" list (which was poorly defined)
  • Similarly, suggestions for root now use the default-created list
  • adding entities via the add-ui no longer uses any kind of transform analysis (it relied on SpaceInfo)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 29, 2024
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! 🎉

@Wumpf Wumpf merged commit fb8d5d9 into main Jan 30, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/remove-space-info branch January 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
2 participants