Make space view names optional and subdue placeholder view label in the UI #4682
Conversation
TODO: - better default name heuristics - fix formatting everywhere in the UI
abey79
changed the title
crates/re_ui/src/lib.rs
Outdated
| // TODO(ab): use design tokens | ||
| text_color = text_color.gamma_multiply(0.5); |
There was a problem hiding this comment.
I'm not sure we should both be doing italics and transparency. Transparency also has an opportunity to be confused with a "grayed out" disabled look. What says @martenbjork ?
There was a problem hiding this comment.
Italics only adds to the visual clutter without conveying the "unnamed" nature of the space view. We should decide:
- either we make the unnamed nature explicit (the the visual language should be strong)
- or we don't (then we apply no formatting at all)
I'm in favour of (1) but happy to discuss how exactly this should be formatted.
For record, we had explored an alternative way of conveying the unnamed nature via the placeholder name (e.g. "unnamed view of XXX"), but ruled it out for its visual clutter.
There was a problem hiding this comment.
Punting on this. With #4802, I will further isolate the location where this formatting happens, so should be easy to revisit.
| ListItem::new(ctx.re_ui, label) | ||
| .unnamed_style(!named) |
There was a problem hiding this comment.
ListItem::new already takes an WidgetText argument. Doesn't it make more sense to separate the formatting of the label from the rest of the ListItem logicl?
There was a problem hiding this comment.
Excellent point. All this styling stuff cramed into ListWidget was really annoying me. I'll do that in a separate PR though, as this cleanup should go beyond what's touched by this PR:
|
Drafting this until @abey79 is back so it gets out of the review queue. |
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
# Conflicts: # crates/re_ui/src/lib.rs # crates/re_ui/src/list_item.rs # crates/re_viewport/src/space_view.rs # crates/re_viewport/src/viewport.rs
…nstead of a tuple with a bool
What
display_nameoptional #4669TODO (future PR)
The selection history popup still needs much work (#4678):
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io