-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make space view display_name
optional
#4669
Comments
Love it! Huge improvement |
I love it too. And +1 on removing the ugly |
I don't have a strong enough opinion to fight for this either way, but I'll note that this runs contrary to most UX designs people are familiar with. Allowing things to have the same name is a recipe for confusion and mistakes. The numbering doesn't have to be dynamic -- it could be based on something else like the last few digits of the space-view UUID. I think the symmetric argument of: "If the ugly (2) bothers, you, then go ahead and name your space view" holds just as well. |
…he UI (#4682) ### What * Fixes #4669 <img width="1577" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/b6e3f768-a25c-4f29-9c4f-1ad00b21f452"> <img width="337" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/dc35124f-3952-42e8-8bc3-1157e4746d6b"> <img width="252" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/383e1a81-c8a6-478d-82c9-44725c8f3ae2"> <img width="248" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/da851f2a-7868-47c2-8d1d-67021e3b40cd"> #### TODO (future PR) The selection history popup still needs much work (#4678): <img width="335" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/e7431e84-a4ba-4b2f-a902-4cbcb85ac84f"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4682/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4682/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4682/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4682) - [Docs preview](https://rerun.io/preview/baa46eca0aedee5c2fd59725d5ce489899149a63/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/baa46eca0aedee5c2fd59725d5ce489899149a63/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
We currently have some kind of heuristic to provide an initial value for space view names, that roughly is:
"$ENTITY_NAME"
, when created from heuristic with a given, non-root space origin"/ ($SPACE_VIEW_TYPE)"
, when the space origin is /"/ (empty $SPACE_VIEW_TYPE)"
, when creating an empty space viewThis is inconsistant, and bit-rots extremely quickly when the use starts editing the space view's content. Plus, (1) contributes to the beginners confusion that "space view ~= entity" in the blueprint tree view.
I propose to make that field
Option
al and update the UI so that some subdued text is displayed until the user actually sets a custom name.The actual text could further be
$SPACE_VIEW_TYPE view of $ENTITY_LAST_SEGMENT
, where entity could be either the space origin, or something derived from the query (if it is simple) e.g.:2D view of /
Text Log view of debug
3D view of points
If a suitable entity cannot be devised, the fallback would be
$SPACE_VIEW_TYPE view
, e.g.Dataframe view
.I further propose to forgo trying to stick a numbering scheme like we do currently (e.g. "/ (2D) (2)"). That numbering would have to be dynamic, which could cause confusion. Also, the synchronised hover/selection highlight should make it clear what corresponds to what. And if there really is confusion, then that's an encouragement for the user to name his views :)
The text was updated successfully, but these errors were encountered: