Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection history list UI #4678

Open
abey79 opened this issue Jan 4, 2024 · 0 comments
Open

Improve selection history list UI #4678

abey79 opened this issue Jan 4, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 4, 2024

The selection history list doesn't follow many of our UI standards and should be improved:

image
  • containers should have icons
  • space view should have icons
  • unnamed space view/containers should have their (placeholder) labels dimmed
@abey79 abey79 added the ui concerns graphical user interface label Jan 4, 2024
abey79 added a commit that referenced this issue Jan 17, 2024
…he UI (#4682)

### What

* Fixes #4669

<img width="1577" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/b6e3f768-a25c-4f29-9c4f-1ad00b21f452">


<img width="337" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/dc35124f-3952-42e8-8bc3-1157e4746d6b">

<img width="252" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/383e1a81-c8a6-478d-82c9-44725c8f3ae2">

<img width="248" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/da851f2a-7868-47c2-8d1d-67021e3b40cd">


#### TODO (future PR)

The selection history popup still needs much work
(#4678):

<img width="335" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/e7431e84-a4ba-4b2f-a902-4cbcb85ac84f">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4682/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4682/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4682/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4682)
- [Docs
preview](https://rerun.io/preview/baa46eca0aedee5c2fd59725d5ce489899149a63/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/baa46eca0aedee5c2fd59725d5ce489899149a63/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant