Skip to content

Commit

Permalink
more lints
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Dec 22, 2023
1 parent 167313a commit 3ae1791
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions crates/re_log_types/src/arrow_msg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ pub struct ArrowChunkReleaseCallback(Arc<dyn Fn(Chunk<Box<dyn Array>>) + Send +
impl std::ops::Deref for ArrowChunkReleaseCallback {
type Target = dyn Fn(Chunk<Box<dyn Array>>) + Send + Sync;

#[inline]
fn deref(&self) -> &Self::Target {
&*self.0
}
Expand Down
2 changes: 1 addition & 1 deletion crates/re_log_types/src/data_table_batcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ pub struct DataTableBatcherConfig {
/// Unbounded if left unspecified.
pub max_tables_in_flight: Option<u64>,

/// Callback to be run when an Arrow [`Chunk`] goes out of scope.
/// Callback to be run when an Arrow Chunk` goes out of scope.
///
/// See [`crate::ArrowChunkReleaseCallback`] for more information.
pub on_release: Option<crate::ArrowChunkReleaseCallback>,
Expand Down
8 changes: 5 additions & 3 deletions rerun_py/src/python_bridge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type GarbageReceiver = crossbeam::channel::Receiver<GarbageChunk>;
///
/// This is an issue in this case because running that callback will likely try and grab the GIL,
/// which is something that should only happen at very specific times, else we end up with deadlocks,
/// segfaults, aborts...
/// segfaults, aborts
///
/// ## The garbage queue
///
Expand Down Expand Up @@ -82,8 +82,10 @@ fn flush_garbage_queue() {
#[cfg(feature = "web_viewer")]
fn global_web_viewer_server(
) -> parking_lot::MutexGuard<'static, Option<re_web_viewer_server::WebViewerServerHandle>> {
static WEB_HANDLE: OnceCell<Mutex<Option<re_web_viewer_server::WebViewerServerHandle>>> =
OnceCell::new();
use once_cell::sync::OnceCell;
static WEB_HANDLE: OnceCell<
parking_lot::Mutex<Option<re_web_viewer_server::WebViewerServerHandle>>,
> = OnceCell::new();
WEB_HANDLE.get_or_init(Default::default).lock()
}

Expand Down

0 comments on commit 3ae1791

Please sign in to comment.