Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New disable_timeline APIs in all supported languages #4068

Merged
merged 9 commits into from
Oct 30, 2023
Merged

New disable_timeline APIs in all supported languages #4068

merged 9 commits into from
Oct 30, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 30, 2023 •
edited by github-actions bot
Loading

Also fix a bug in the C/C++ SDKs where only sequential timelines would be disabled.

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) 🌊 C++ API C/C++ API specific include in changelog labels Oct 30, 2023
@teh-cmc teh-cmc changed the title New disable_timeline APIs everywhere New disable_timeline APIs in all supported languages Oct 30, 2023
teh-cmc
teh-cmc commented Oct 30, 2023
View reviewed changes
crates/rerun_c/src/lib.rs
@@ -533,7 +533,7 @@ fn rr_recording_stream_disable_timeline_impl(
timeline_name: CStringView,
) -> Result<(), CError> {
let timeline = timeline_name.as_str("timeline_name")?;
recording_stream(stream)?.set_time_sequence(timeline, None);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ bug ⚠️

@teh-cmc teh-cmc force-pushed the cmc/disable_timeline branch from bd77b33 to 1b85b93 Compare October 30, 2023 11:15
emilk
emilk requested changes Oct 30, 2023
View reviewed changes
crates/re_sdk/src/recording_stream.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/recording_stream.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/recording_stream.rs Outdated Show resolved Hide resolved
crates/rerun_c/src/rerun.h Outdated Show resolved Hide resolved
@teh-cmc teh-cmc requested a review from emilk October 30, 2023 13:21
emilk
emilk approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we should also remove disable_timeline_specific

crates/re_sdk/src/recording_stream.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member

emilk commented Oct 30, 2023

New issue:

@teh-cmc teh-cmc merged commit 85949ce into main Oct 30, 2023
19 of 25 checks passed
@teh-cmc teh-cmc deleted the cmc/disable_timeline branch October 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce rr.disable_timeline in Python and Rust
2 participants
@teh-cmc @emilk