Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rr.disable_timeline in Python and Rust #3845

Closed
teh-cmc opened this issue Oct 12, 2023 · 0 comments · Fixed by #4068
Closed

Introduce rr.disable_timeline in Python and Rust #3845

teh-cmc opened this issue Oct 12, 2023 · 0 comments · Fixed by #4068
Assignees
@teh-cmc
Labels
🐍 Python API Python logging API 🦀 Rust API Rust logging API
Milestone
0.11

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Oct 12, 2023

C++ is about to introduce rr.disable_timeline, which replaces rr.set_time_sequence("timeline", None).

We should be consistent across our SDKs, and apply the same change to the Python and Rust SDKs.
@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API labels Oct 12, 2023
@Wumpf Wumpf added this to the 0.11 C++ polish milestone Oct 24, 2023
@teh-cmc teh-cmc self-assigned this Oct 27, 2023
@teh-cmc teh-cmc mentioned this issue Oct 30, 2023
Merged
4 tasks
teh-cmc added a commit that referenced this issue Oct 30, 2023
@teh-cmc
New disable_timeline APIs in all supported languages (#4068)
85949ce 
Also fix a bug in the C/C++ SDKs where only sequential timelines would
be disabled.

- Fixes #3845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

New disable_timeline APIs in all supported languages rerun-io/rerun
2 participants
@Wumpf @teh-cmc