Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid having two timelines with the same name #4080

Open
emilk opened this issue Oct 30, 2023 · 0 comments
Open

Forbid having two timelines with the same name #4080

emilk opened this issue Oct 30, 2023 · 0 comments
Labels
enhancement New feature or request 🚜 refactor Change the code, not the functionality user-request This is a pressing issue for one of our users
Milestone
Triage

Comments

@emilk
Copy link
Member

emilk commented Oct 30, 2023 •
edited
Loading

It is currently possible to have a sequence timeline and a temporal timeline, both with the same name. This seems like a very bad idea, just opening up for confusion.

This means TimePoint should go from:

pub struct TimePoint(BTreeMap<Timeline, TimeInt>)

to:

pub struct TimePoint(BTreeMap<TimelineName, (TimeType, TimeInt)>)

(TimeType, TimeInt) should probably be its own struct though with a clever name.
Perhaps Time, except that is a name-clash.
@emilk emilk added the enhancement New feature or request label Oct 30, 2023
@emilk emilk added this to the Triage milestone Oct 30, 2023
@emilk emilk mentioned this issue Oct 30, 2023
Merged
4 tasks
@emilk emilk added the 🚜 refactor Change the code, not the functionality label Jan 9, 2024
@emilk emilk mentioned this issue Jan 15, 2024
Open
@emilk emilk mentioned this issue Aug 9, 2024
Merged
6 tasks
@teh-cmc teh-cmc added the user-request This is a pressing issue for one of our users label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 🚜 refactor Change the code, not the functionality user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
Triage
Development

No branches or pull requests
2 participants
@emilk @teh-cmc