Minor fixes/improvements of upload_image.py
#2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Mac, PIL's clipboard import compresses to JPG, which is bad => added a custom function to use PNG instead. - Tuned the PIL image saving parameters to optimise for file size - Added some pngcrush CLI parameter for optimisation - Discard pngcrush output if it ends up bigger than output (PIL's PNG export is pretty good in most cases it seems)
emilk
approved these changes
Jun 15, 2023
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
### What Lessons learned from #2440 - On Mac, PIL's clipboard import compresses to JPG, which is bad => added a custom function to use PNG instead. - Tuned the PIL image saving parameters to optimise for file size - Added some pngcrush CLI parameter for optimisation - Discard pngcrush output if it ends up bigger than output (PIL's PNG export is pretty good in most cases it seems) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] ~~I've included a screenshot or gif (if applicable)~~ <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2449 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8563e84/docs Examples preview: https://rerun.io/preview/8563e84/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Lessons learned from #2440
Checklist
I've included a screenshot or gif (if applicable)PR Build Summary: https://build.rerun.io/pr/2449
Docs preview: https://rerun.io/preview/8563e84/docs
Examples preview: https://rerun.io/preview/8563e84/examples