-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New screenshots and thumbnails for the examples #2440
Conversation
### What Lessons learned from #2440 - On Mac, PIL's clipboard import compresses to JPG, which is bad => added a custom function to use PNG instead. - Tuned the PIL image saving parameters to optimise for file size - Added some pngcrush CLI parameter for optimisation - Discard pngcrush output if it ends up bigger than output (PIL's PNG export is pretty good in most cases it seems) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] ~~I've included a screenshot or gif (if applicable)~~ <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2449 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8563e84/docs Examples preview: https://rerun.io/preview/8563e84/examples <!-- pr-link-docs:end -->
### What Lessons learned from #2440 - On Mac, PIL's clipboard import compresses to JPG, which is bad => added a custom function to use PNG instead. - Tuned the PIL image saving parameters to optimise for file size - Added some pngcrush CLI parameter for optimisation - Discard pngcrush output if it ends up bigger than output (PIL's PNG export is pretty good in most cases it seems) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] ~~I've included a screenshot or gif (if applicable)~~ <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2449 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8563e84/docs Examples preview: https://rerun.io/preview/8563e84/examples <!-- pr-link-docs:end -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic on my end for both desktop and mobile (I find it looks even better on mobile in fact).
Some random feedback, nothing blocking:
- Navigating the examples on github now looks kinda weird with the front matter turning into a huge weirdly formatted and cropped in half table:
Can't we hide that stuff behind a comment or something? - I find it very hard to see what's going on in the right hand side of the colmap screenshot (is it the angle? not enough visible history?):
If I wasn't so familiar with it i'm not sure I'd have any idea what I'm looking at. Might just be me. - Similarly, I have a hard time making out the shape in the tensor view used in the SDF example:
Not sure whether that's due to the settings used in the view (need to tweak colormapping etc) or just the mesh itself which doesn't lend itself too well to the exercise (the lamp pole mesh makes for a way clearer demo in my experience). - The DICOM example could really use some color:
Maybe add a second view with a turbo map applied?
|
Yeah, I had the same concern regarding the frontmatter rendering in the initial PR (#2309). I wish GH would just hide it. But we can change it to something like
Another option is to move it to a different file. Either way making the required changes to landing would not be too much work |
oof I tried hard already to extract anything out of that is visible, switched through different color maps and found that one the most visible one |
I've never seen these artifacts before in my life actually 😄 |
The sad part about this is that the front matter format is sort of standard and benefits from tooling checks, etc. |
I suppose this runs into some GL bugs on Mac (or GL being GL uses some less defined cases) |
@teh-cmc this is what I get for the lamppole... |
Merging this. We'll improve the SDF example later on. |
What
This PR updates the examples' READMEs with new screenshots and adds the
thumbnail:
entry to their front matter.This uses #2411 and highlighted some bugs with it, to be fixed in a follow-up PR.
TODO:
Checklist
PR Build Summary: https://build.rerun.io/pr/2440
Docs preview: https://rerun.io/preview/b2d508b/docs
Examples preview: https://rerun.io/preview/b2d508b/examples