Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weird-looking argument parsing in examples #2398

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 12, 2023

What

Closes #2217

Remove weird-looking argument parsing in examples. We only added them in #1927 because of run_all.py.

Checklist

PR Build Summary: https://build.rerun.io/pr/2398

Docs preview: https://rerun.io/preview/26bc44f/docs
Examples preview: https://rerun.io/preview/26bc44f/examples

@emilk emilk added the examples Issues relating to the Rerun examples label Jun 12, 2023
@teh-cmc teh-cmc self-requested a review June 13, 2023 13:16
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try to run-all myself but lgtm otherwise

@emilk emilk merged commit 2cf3d39 into main Jun 13, 2023
@emilk emilk deleted the emilk/fix-weird-argparsing-in-examples branch June 13, 2023 14:27
emilk added a commit that referenced this pull request Jun 15, 2023
### What
Closes #2217

Remove weird-looking argument parsing in examples. We only added them in
#1927 because of `run_all.py`.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2398

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/26bc44f/docs
Examples preview: https://rerun.io/preview/26bc44f/examples
<!-- pr-link-docs:end -->
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird looking arg-parser logic in examples
2 participants