-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird looking arg-parser logic in examples #2217
Labels
😤 annoying
Something in the UI / SDK is annoying to use
examples
Issues relating to the Rerun examples
🏎️ Quick Issue
Can be fixed in a few hours or less
Comments
jleibs
added
😤 annoying
Something in the UI / SDK is annoying to use
examples
Issues relating to the Rerun examples
labels
May 25, 2023
We should really try to avoid making our examples less clear in order to make it easer for devs to run all examples. Better to put that complexity in our helper scripts |
100%. This is the |
emilk
changed the title
Weird looking arg-parser logic in minimal example
Weird looking arg-parser logic in examples
Jun 12, 2023
1 task
emilk
added a commit
that referenced
this issue
Jun 13, 2023
### What Closes #2217 Remove weird-looking argument parsing in examples. We only added them in #1927 because of `run_all.py`. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2398 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/26bc44f/docs Examples preview: https://rerun.io/preview/26bc44f/examples <!-- pr-link-docs:end -->
emilk
added a commit
that referenced
this issue
Jun 15, 2023
### What Closes #2217 Remove weird-looking argument parsing in examples. We only added them in #1927 because of `run_all.py`. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2398 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/26bc44f/docs Examples preview: https://rerun.io/preview/26bc44f/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
😤 annoying
Something in the UI / SDK is annoying to use
examples
Issues relating to the Rerun examples
🏎️ Quick Issue
Can be fixed in a few hours or less
The minimal example now contains the code:
with no comment or other explanation.
I believe this may be a workaround to keep things from failing in conjunction with the run-all script, but this seems like the wrong approach. This complexity should be moved into the runner, not obscuring the example code.
The text was updated successfully, but these errors were encountered: