Update wgpu-hal to 0.16.1 to fix mobile Safari #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release contains gfx-rs/wgpu#3780 Closes #2032
emilk
added
🪳 bug
Wumpf
approved these changes
Jun 1, 2023
Comment on lines
+123
to
+127
| anyhow::bail!( | ||
| "Failed to run wasm-bindgen: {err}. This is often because some dependency is calling `std::time::Instant::now()` or similar. You can try diagnosing this with:\n\ | ||
| wasm2wat {target_wasm_path} | rg '\"env\"'\n\ | ||
| wasm2wat {target_wasm_path} | rg 'call .now\\b' -B 20" | ||
| ); |
There was a problem hiding this comment.
very nice, didn't know about wasm2wat (I use a VSCode plugin for that sort of thing so far)
There was a problem hiding this comment.
"the" webassembly extension can convert wasm files https://marketplace.visualstudio.com/items?itemName=dtsvet.vscode-wasm
emilk
added a commit
that referenced
this pull request
Jun 15, 2023
The release contains gfx-rs/wgpu#3780 Closes #2032 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2296 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/9ebf96a/docs <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release contains gfx-rs/wgpu#3780
Closes #2032
Checklist
PR Build Summary: https://build.rerun.io/pr/2296
Docs preview: https://rerun.io/preview/9ebf96a/docs