Fix missing 4X MSAA support on some OpenGL backends #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2023
emilk
changed the title
Wumpf
requested changes
May 17, 2023
Wumpf
approved these changes
May 17, 2023
emilk
added a commit
to rerun-io/wgpu
that referenced
this pull request
May 22, 2023
* Always support 4x MSAA on GL * Update changelog
cwfitzgerald
pushed a commit
that referenced
this pull request
May 25, 2023
* Always support 4x MSAA on GL * Update changelog
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
May 25, 2023
This was referenced May 30, 2023
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jun 1, 2023
The release contains gfx-rs/wgpu#3780 Closes #2032
1 task
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jun 1, 2023
The release contains gfx-rs/wgpu#3780 Closes #2032 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2296 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/9ebf96a/docs <!-- pr-link-docs:end -->
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jun 15, 2023
The release contains gfx-rs/wgpu#3780 Closes #2032 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2296 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/9ebf96a/docs <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
A regression was introduced in wgpu 0.15 by #3140, where some GL backends would report a minimum supported MSAA of 2x. However, GLES3.0 (and therefore WebGL2) guarantees at least 4x.
This problem manifests itself on some versions of iOS Safari, where
get_parameter_i32(glow::MAX_SAMPLES)returns0(for unknown reasons - maybe anti-fingerprinting?), even though 4x MSAA is supported.Testing
Tested on iOS Safari. Before the fix I got:
After the fix, everything works (with 4x MSAA).