Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wasm-bindgen-cli with library wasm-bindgen-cli-support #2257

Merged
merged 1 commit into from
May 29, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 29, 2023

Makes the build a bit more hermetic

Closes #2225

Checklist

PR Build Summary: https://build.rerun.io/pr/2257

@emilk emilk added the 🧑‍💻 dev experience developer experience (excluding CI) label May 29, 2023
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@Wumpf Wumpf merged commit b263b9f into main May 29, 2023
@Wumpf Wumpf deleted the emilk/remove-wasm-bindgen-cli branch May 29, 2023 18:20
emilk added a commit that referenced this pull request Jun 15, 2023
Makes the build a bit more hermetic

Closes #2225

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2257
@emilk emilk mentioned this pull request Jun 15, 2023
3 tasks
@emilk emilk changed the title Replace wasm-bindgen-cli with library wasm-bindgen-cli-support Replace wasm-bindgen-cli with library wasm-bindgen-cli-support Jun 15, 2023
@emilk emilk mentioned this pull request Jun 15, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the wasm-bindgen library rather than the CLI
2 participants