Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the wasm-bindgen library rather than the CLI #2225

Closed
teh-cmc opened this issue May 25, 2023 · 1 comment · Fixed by #2257
Closed

Use the wasm-bindgen library rather than the CLI #2225

teh-cmc opened this issue May 25, 2023 · 1 comment · Fixed by #2257
Assignees
@emilk
Labels
💬 discussion 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@teh-cmc
Copy link
Member

teh-cmc commented May 25, 2023

So that we don't have to depend on the CLI binary that's installed on the developer's machine.
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label May 29, 2023
@emilk
Copy link
Member

emilk commented May 29, 2023

It seems doable if we are willing to use wasm-bindgen-cli-support, which wasm-bindgen-cli is just thing wrapper around.

@emilk emilk self-assigned this May 29, 2023
@emilk emilk mentioned this issue May 29, 2023
Merged
1 task
Wumpf pushed a commit that referenced this issue May 29, 2023
@emilk
Replace wasm-bindgen-cli with library wasm-bindgen-cli-support (#2257)
b263b9f 
Makes the build a bit more hermetic

Closes #2225

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2257
@emilk emilk changed the title Investigate whether we can use the wasm-bindgen library rather than the CLI Use the wasm-bindgen library rather than the CLI Jun 9, 2023
emilk added a commit that referenced this issue Jun 15, 2023
@emilk
Replace wasm-bindgen-cli with library wasm-bindgen-cli-support (#2257)
7772b25 
Makes the build a bit more hermetic

Closes #2225

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
💬 discussion 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace wasm-bindgen-cli with library wasm-bindgen-cli-support rerun-io/rerun
2 participants
@emilk @teh-cmc