Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep rerun viewer from dying on ctrl-c by setting sid on unix systems #6260

Merged
merged 2 commits into from
May 8, 2024
Merged

Keep rerun viewer from dying on ctrl-c by setting sid on unix systems #6260

merged 2 commits into from
May 8, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 7, 2024 •
edited by github-actions bot
Loading

What

Testing:

  • Works on linux
  • Works on Mac
  • Works on Windows

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐧 linux Linux-specific problems include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍎 MacOS Issues specifically about MacOS support labels May 7, 2024
@jleibs jleibs marked this pull request as ready for review May 7, 2024 18:01
@Wumpf Wumpf self-requested a review May 8, 2024 14:40
Wumpf
Wumpf approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, like how minimal this solution turned out

crates/re_sdk/src/spawn.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/spawn.rs Outdated Show resolved Hide resolved
@jleibs jleibs merged commit 1942b43 into main May 8, 2024
33 of 34 checks passed
@jleibs jleibs deleted the jleibs/spawn_setsid branch May 8, 2024 16:31
@emilk emilk changed the title Keep rerun viewer from dying on ctrl-c by setting sid on unix systems Keep rerun viewer from dying on ctrl-c by setting sid on unix systems May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🍎 MacOS Issues specifically about MacOS support include in changelog 🐧 linux Linux-specific problems 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl-c kills Rerun view in addition to python application
2 participants
@jleibs @Wumpf