-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the orbit eye to always maintain an up-axis #5193
Conversation
6b0f2d7
to
a5c3b5c
Compare
a5c3b5c
to
f3b3452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels pretty great!
It can be very hard to see the up-axis on the orbit eye center visualization depending on the angle, not sure what we can do about this... Actually, come to think of it, it's hard to see any axis on that visualization: could it be a gizmo-like thing similar to what we do for transforms? (Then again all things ViewCoordinates really confuse me so maybe that doesn't make any sense.)
There is a lurking bug in tilted mode where the camera will just stop behaving appropriately (you can do full orbits, controls start to do random-looking things, etc).
I have no other repro steps than "play around with the middle-mouse button":
24-02-15_09.27.38.patched.mp4
I don't think that's blocking, it's hard to trigger and easy to get out of (just double click).
What
ViewCoordinates
).orbit-camera-up-axis.mp4
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io