-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return errors on invalid entity paths #3393
Comments
emilk
added
enhancement
New feature or request
👀 needs triage
This issue needs to be triaged by the Rerun team
🪳 bug
Something isn't working
💣 crash
crash, deadlock/freeze, do-no-start
and removed
👀 needs triage
This issue needs to be triaged by the Rerun team
enhancement
New feature or request
labels
Sep 21, 2023
This was referenced Sep 22, 2023
Another solution to this is to allow anything as an entity path, and just doing our best to parse and interpret it, and perhaps log a warning if does not follow our preferred style. |
emilk
added a commit
that referenced
this issue
Sep 25, 2023
Closes #3393 For the Python and Rust SDK, any string is now a valid entity path, though perhaps not the one you where expecting. A warning is printed if the format is not the normalized format. For C/C++ I opted to still use the strict parsing for now. We can revisit that later.
emilk
added a commit
that referenced
this issue
Sep 25, 2023
Closes #3393 For the Python and Rust SDK, any string is now a valid entity path, though perhaps not the one you where expecting. A warning is printed if the format is not the normalized format. For C/C++ I opted to still use the strict parsing for now. We can revisit that later.
emilk
added a commit
that referenced
this issue
Sep 25, 2023
Closes #3393 For the Python and Rust SDK, any string is now a valid entity path, though perhaps not the one you where expecting. A warning is printed if the format is not the normalized format. For C/C++ I opted to still use the strict parsing for now. We can revisit that later. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3443) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3443) - [Docs preview](https://rerun.io/preview/2d8c818b7175d8daec5149ff1bb4442a1501e5f3/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/2d8c818b7175d8daec5149ff1bb4442a1501e5f3/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have this in our code:
This means that passing an invalid entity path (e.g.
///åmål!
) to Rerun can crash the SDK, viewer, or both.We should remove these and return errors on invalid paths instead.
The text was updated successfully, but these errors were encountered: