Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any string as an entity path #3443

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Allow any string as an entity path #3443

merged 4 commits into from
Sep 25, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 25, 2023 •
edited by github-actions bot
Loading

Closes #3393

For the Python and Rust SDK, any string is now a valid entity path, though perhaps not the one you where expecting. A warning is printed if the format is not the normalized format.

For C/C++ I opted to still use the strict parsing for now. We can revisit that later.

Checklist

@emilk
Make entity path parsing infallible by default
bbed0af 
Closes #3393

For the Python and Rust SDK, any string is now a valid entity path,
though perhaps not the one you where expecting. A warning is printed
if the format is not the normalized format.

For C/C++ I opted to still use the strict parsing for now.
We can revisit that later.
@emilk emilk force-pushed the emilk/forgiving-parse-of-entity-paths branch from 435c006 to bbed0af Compare September 25, 2023 10:19
@Wumpf Wumpf self-requested a review September 25, 2023 12:05
Wumpf
Wumpf requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If changing to .as_bytes to .chars is too big right now let's open an issue and move on. Seems quite important though to me!

crates/re_log_types/src/path/parse_path.rs Outdated Show resolved Hide resolved
crates/re_log_types/src/path/parse_path.rs Show resolved Hide resolved
crates/rerun_c/src/lib.rs Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Sep 25, 2023

thanks for clarifying comments :)

@emilk emilk merged commit 83f009d into main Sep 25, 2023
26 checks passed
@emilk emilk deleted the emilk/forgiving-parse-of-entity-paths branch September 25, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return errors on invalid entity paths
2 participants
@emilk @Wumpf