-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click recording://entity/path
links in markdown
#3389
Conversation
|
||
### Colored 3D Points | ||
The colored 3D points were added to the scene by logging the | ||
[rr.Points3D archetype](https://www.rerun.io/docs/reference/data_types/point3d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have loved to be able to write
[`rr.Points3D` archetype](https://www.rerun.io/docs/reference/data_types/point3d)
here instead to make the rr.Points3D
be formatted as both code and a link but not super important.
Would be super cool to also be able to refer to a specific time point but I'd need input on what that uri should look like |
…ko/markdown-example-with-data-link
recording://entity/path
links in markdown
Of course you can also have [normal https links](https://github.com/rerun-io/rerun), e.g. <https://rerun.io>. | ||
|
||
## Image | ||
![A random image](https://picsum.photos/640/480) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something tells me it would be nicer to not add randomness to these but probably no big deal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone else should review this, since I wrote most of the code in it 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, that was a lot of new path handling to take in, but looked all sound to me :)
Given that path parsing is quite central, I'm advocating for filling a few test gaps there.
now we need a Rerun markdown quine 😄
/// * `points.Color` | ||
/// * `points[#42]` | ||
/// * `points[#42].Color` | ||
pub struct DataPath { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed that InstancePath
is the odd one out - it's in re_data_store unlike the others and has an overlapping relationship with DataPath
. Might be nice to put them all next to each other in a follow-up PR and have an overview over all types of paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is odd because it depends on InstanceKey
which is a code-genned thing that lives in re_types
. I guess we could move all paths to re_types
though at some point soon.
44e6b22
to
2902399
Compare
Styling links based on the URI is not really possible at this point |
I'm a bit hesitant merging this, as it will break existing code. I'm leaning towards implementing |
if we want to disallow If on the other hand we make this defined behavior, we might need to take special care that we firmly establish |
The core problem is that So we either need to forbid |
Ok, parsing entity paths is very forgiving again, but logs a warning when not written in their "proper" form. We could consider making entity parsing forgiving of any error, thus solving #3393 by simply allowing anything as an entity path. |
# Conflicts: # crates/re_types/source_hash.txt
# Conflicts: # crates/re_types/source_hash.txt
something went wrong when merging. Rebased in #3442 |
What
You can now embed links to entities in markdown documents using
recording://entity/path
, and link to components usingrecording://entity/path.Color
.In order to support this, a new
DataPath
is introduced, with a stricter parsing of entity paths. Previouslyfoo bar
was a valid path, but now you are only allowed ASCII, numbers, underscore and dash as names (outside of quotes).A (uncompleted) description of the SfM example as markdown to
Checklist