Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colormap selection preview is sometimes bugged, sometimes not there at all #3242

Closed
teh-cmc opened this issue Sep 7, 2023 · 2 comments · Fixed by #3373
Closed

Colormap selection preview is sometimes bugged, sometimes not there at all #3242

teh-cmc opened this issue Sep 7, 2023 · 2 comments · Fixed by #3373
Assignees
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 7, 2023

Here's a colormap selector for depth clouds -- no preview at all:
image

And here's a colormap selector for tensors -- layout is broken:
image

@teh-cmc teh-cmc added ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release labels Sep 7, 2023
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Sep 11, 2023
@emilk emilk self-assigned this Sep 13, 2023
@emilk
Copy link
Member

emilk commented Sep 14, 2023

So there are two problems here:

A) we have two different code paths for selecting a colormap, and only one has the preview
B) the preview is broken

@emilk emilk removed their assignment Sep 14, 2023
@emilk
Copy link
Member

emilk commented Sep 14, 2023

The viewport given to new_renderer_callback for each gradient image is correct:

image

So the problem is either in

  • how egui_wgpu handles the callback (maybe broke in Improved wgpu callbacks emilk/egui#3253)
  • our rectangle shader (re_renderer::renderer::TexturedRect)
  • our transforms (re_renderer::view_builder::TargetConfiguration)

emilk added a commit that referenced this issue Sep 14, 2023
The thing called `clip_rect` is actually a `viewport`, which initially
confused me.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3324) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3324)
- [Docs
preview](https://rerun.io/preview/301c18280ba0899ccb30e6e8c3357837c280b475/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/301c18280ba0899ccb30e6e8c3357837c280b475/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@Wumpf Wumpf self-assigned this Sep 19, 2023
emilk pushed a commit that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants