-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colormap selection preview is sometimes bugged, sometimes not there at all #3242
Labels
🏎️ Quick Issue
Can be fixed in a few hours or less
🦟 regression
A thing that used to work in an earlier release
ui
concerns graphical user interface
Comments
teh-cmc
added
ui
concerns graphical user interface
🦟 regression
A thing that used to work in an earlier release
labels
Sep 7, 2023
So there are two problems here: A) we have two different code paths for selecting a colormap, and only one has the preview
|
The So the problem is either in
|
emilk
added a commit
that referenced
this issue
Sep 14, 2023
emilk
added a commit
that referenced
this issue
Sep 14, 2023
The thing called `clip_rect` is actually a `viewport`, which initially confused me. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3324) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3324) - [Docs preview](https://rerun.io/preview/301c18280ba0899ccb30e6e8c3357837c280b475/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/301c18280ba0899ccb30e6e8c3357837c280b475/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
3 tasks
emilk
pushed a commit
that referenced
this issue
Sep 21, 2023
…3373) ### What * Fixes #3242 ![image](https://github.com/rerun-io/rerun/assets/1220815/6f7de264-5a08-4aa6-96a4-06c58816ae86) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3373) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3373) - [Docs preview](https://rerun.io/preview/73ad32ebf606b6d91192ca5c490d0b158c79f769/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/73ad32ebf606b6d91192ca5c490d0b158c79f769/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏎️ Quick Issue
Can be fixed in a few hours or less
🦟 regression
A thing that used to work in an earlier release
ui
concerns graphical user interface
Here's a colormap selector for depth clouds -- no preview at all:
And here's a colormap selector for tensors -- layout is broken:
The text was updated successfully, but these errors were encountered: