Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming of things to help diagnose #3242 #3324

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 14, 2023

The thing called clip_rect is actually a viewport, which initially confused me.

Checklist

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 14, 2023
@emilk emilk merged commit 899a7d2 into main Sep 14, 2023
28 checks passed
@emilk emilk deleted the emilk/investigate-3242 branch September 14, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant