Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image zoom rectangle is off by one pixel #3074

Closed
roym899 opened this issue Aug 22, 2023 · 0 comments · Fixed by #4590
Closed

Image zoom rectangle is off by one pixel #3074

roym899 opened this issue Aug 22, 2023 · 0 comments · Fixed by #4590
Assignees
@Wumpf
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🔺 re_renderer affects re_renderer itself
Milestone
Triage

Comments

@roym899
Copy link
Collaborator

roym899 commented Aug 22, 2023

Describe the bug
Follow up on #2236. The center is correct now, but the right and bottom border are off one pixel in the little preview, compared to the box overlay shown in the image.

Note the black row / column showing up, while the white border aligns with the image boundary.

2023-08-22-pixeldetail.mp4

Rerun version

rerun_py 0.8.0 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] x86_64-unknown-linux-gnu main df05f49, built 2023-07-27T17:36:23Z
@roym899 roym899 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 22, 2023
@Wumpf Wumpf added 😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 25, 2023
@emilk emilk added this to the 0.10 C++ milestone Sep 6, 2023
@emilk emilk changed the title Pixel detail box border one pixel off Image zoom rectangle is off by one pixel Sep 14, 2023
@emilk emilk self-assigned this Sep 14, 2023
@emilk emilk mentioned this issue Sep 14, 2023
Closed
@emilk emilk removed their assignment Sep 14, 2023
@emilk emilk added the 🔺 re_renderer affects re_renderer itself label Oct 9, 2023
@teh-cmc teh-cmc assigned teh-cmc and unassigned teh-cmc Oct 10, 2023
@Wumpf Wumpf self-assigned this Dec 19, 2023
@Wumpf Wumpf mentioned this issue Dec 19, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Dec 20, 2023
@Wumpf @teh-cmc
Fix rectangle that indicates the zoomed pixel area on hover being one…
10e093f 
… pixel to small (#4590)

### What

* Fixes #3074

The outlines of the zoomed rectangle that we super-impose on the 2D
space view were off by one pixel

Before:
![Screenshot 2023-12-19
174351](https://github.com/rerun-io/rerun/assets/1220815/c624c81a-cac9-4efc-a278-5b98847c9963)
Note how the rectangle on the picture is smaller than the zoomed-preview
(zoomed out in this case)

After:
![Screenshot 2023-12-19
175201](https://github.com/rerun-io/rerun/assets/1220815/5b8e2132-7cf4-40b6-bc54-bdbd2cec39d0)
Note how the rectangle on the picture is identically to the
zoomed-preview. The hover overlay hasn't changed, but a different pixel
is hovered and the rect is correctly sized now


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [ ] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4590/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4590/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4590/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4590)
- [Docs
preview](https://rerun.io/preview/4b0954988c67c9227677ff8609dd231737bf929a/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4b0954988c67c9227677ff8609dd231737bf929a/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Fix rectangle that indicates the zoomed pixel area on hover being one pixel to small rerun-io/rerun
4 participants
@emilk @Wumpf @teh-cmc @roym899