Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rectangle that indicates the zoomed pixel area on hover being one pixel to small #4590

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 19, 2023

What

The outlines of the zoomed rectangle that we super-impose on the 2D space view were off by one pixel

Before:
Screenshot 2023-12-19 174351
Note how the rectangle on the picture is smaller than the zoomed-preview (zoomed out in this case)

After:
Screenshot 2023-12-19 175201
Note how the rectangle on the picture is identically to the zoomed-preview. The hover overlay hasn't changed, but a different pixel is hovered and the rect is correctly sized now

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

… pixel to small

The outlines of the zoomed rectangle that we super-impose on the 2D space view were off by one pixel
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Dec 19, 2023
crates/re_data_ui/src/image.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 10e093f into main Dec 20, 2023
21 of 30 checks passed
@Wumpf Wumpf deleted the andreas/fix-off-by-one-in-pixel-rect branch December 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image zoom rectangle is off by one pixel
2 participants