Skip to content

Fix site customize 2#275

Merged
airportyh merged 2 commits intomainfrom
th-fix-site-customize-2
Mar 1, 2024
Merged

Fix site customize 2#275
airportyh merged 2 commits intomainfrom
th-fix-site-customize-2

Conversation

@airportyh
Copy link
Collaborator

@airportyh airportyh commented Mar 1, 2024

Why

Oops, I merged the #272 before testing. sitecustomize.py broke: it contained the path to the file rather than the contents. This fixes it (version 2).

Test Plan

  1. create a Python Repl
  2. pip install gunicorn
  3. cat .pythonlibs/bin/gunicorn see that the shebang line starts with #!/usr/bin/env python3
  4. make sure template tests (in particular pip and poetry tests) pass
  5. pip install --upgrade pip
  6. which pip to see we are using the pip inside .pythonlibs
  7. try using that pip to install a thing: pip install flask

@airportyh airportyh requested a review from a team as a code owner March 1, 2024 15:57
@airportyh airportyh requested review from blast-hardcheese and removed request for a team March 1, 2024 15:57
@airportyh
Copy link
Collaborator Author

Upgradable pip!
image

@airportyh
Copy link
Collaborator Author

Verified the shebang line works even with the upgraded version of pip.

@airportyh airportyh merged commit 8c258bf into main Mar 1, 2024
@airportyh airportyh deleted the th-fix-site-customize-2 branch March 1, 2024 16:26
@airportyh airportyh mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments