Update nix channel for python; use stock pip; monkeypatch pip to chan…#272
Merged
Update nix channel for python; use stock pip; monkeypatch pip to chan…#272
Conversation
d8011fd to
37d9b80
Compare
Collaborator
Author
|
@blast-hardcheese I think we should expose |
0ae8bf9 to
9a725e0
Compare
Collaborator
Author
|
@blast-hardcheese I think we want to make the script not break if for some reason pip was not available on PYTHONPATH. |
Collaborator
Author
|
I can't find a way to break it by setting the PYTHONPATH though, so it ok. |
Collaborator
|
I'm concerned about the test plan here, because it already does what the test plan says without this change. |
Contributor
|
@ryantm That won't be true in the upgraded nixmodules -- that is the case today, and our goal is to effectively have a noop through this upgrade |
Contributor
|
@airportyh if |
blast-hardcheese
approved these changes
Feb 29, 2024
ryantm
approved these changes
Feb 29, 2024
9a725e0 to
2250a9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ge shebang line
Why
a. use the stock pip instead of our custom one
b. add back a customization for the shebang line via monkeypatching, via python site customization, which has the advantage of working for a pip that's been installed in .pythonlibs. Thanks @blast-hardcheese for this!
What changed
break-system-packages = yesto silence this errorTest plan
pip install gunicorncat .pythonlibs/bin/gunicornsee that the shebang line starts with#!/usr/bin/env python3