Conversation
airportyh
force-pushed
the
th-sitecustomize-subdir
branch
from
450f1aa to
975f378
Compare
ryantm
approved these changes
Mar 4, 2024
Collaborator
Author
It was already a file in a folder, but this makes it go in more nested folders. I believe it would be a single file wo a destination specified. |
airportyh
force-pushed
the
th-sitecustomize-subdir
branch
from
975f378 to
8219ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We found that the sitecustomize.py setup we added makes pyright hang when starting up, and we had failed lsp tests.
https://replit.slack.com/archives/C06KAKG35QS/p1709318856982249?thread_ts=1709316270.385049&cid=C06KAKG35QS
What changed
Moved sitecustomize.py to a subdirectory
lib/python/site-packagesto prevent pyright from trying to walk up and list the files in/nix/storeTest plan
Same as in #275