Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a trailing log line in case another playwright reporter removes our last line #613

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

hbenl
Copy link
Contributor

@hbenl hbenl commented Jul 9, 2024

No description provided.

@hbenl hbenl requested review from bvaughn and Andarist July 9, 2024 11:37
@hbenl hbenl self-assigned this Jul 9, 2024
Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 23ff98e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@replayio/playwright Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

replay-io bot commented Jul 9, 2024

Status In Progress ↗︎
Commit d1e1aad
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @@ -403,6 +403,8 @@ export default class ReplayPlaywrightReporter implements Reporter {
    console.warn(`[replay.io]: ${line}`);
    });
    }

    console.log("[replay.io]:");
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This looks really odd on its own. Maybe we could add some text to this, like this?

    Suggested change
    console.log("[replay.io]:");
    console.log("[replay.io]: Completed");

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I don't think it looks odd since we already output some (almost) empty lines like this. I see this line as padding.

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This padding always bothered me - I intuitively expected to find some extra text below it. I think Brian had similar sentiment since he removed this recently here.

    Perhaps it's the fact that this line is not completely empty (it has our prefix) makes is weird to me 🤷‍♂️

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'd prefer if this were just be an empty line :) but it's at least better this way than for Playwright to trim it off.

    @hbenl hbenl requested a review from Andarist July 9, 2024 11:51
    //
    // reporters: [replayReporter({ upload: true }), ['line']]
    //
    // that can lead to removing *our* last log line
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    // that can lead to removing *our* last log line
    // that can lead to removing *our* last log line
    //
    // the issue is tracked here: https://github.com/microsoft/playwright/issues/23875

    @hbenl hbenl merged commit 8cd22ea into main Jul 9, 2024
    7 checks passed
    @hbenl hbenl deleted the hbenl/pro-775 branch July 9, 2024 12:02
    @github-actions github-actions bot mentioned this pull request Jul 9, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants