Merge 23ff98e into 190165f

replayio · Jul 9, 2024 · d1e1aad · d1e1aad
2 parents 190165f + 23ff98e
commit d1e1aad
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/.changeset/empty-brooms-cross.md b/.changeset/empty-brooms-cross.md
@@ -0,0 +1,5 @@
+---
+"@replayio/playwright": patch
+---
+
+Add a trailing log line in case another playwright reporter removes our last line
diff --git a/packages/playwright/src/reporter.ts b/packages/playwright/src/reporter.ts
@@ -403,6 +403,19 @@ export default class ReplayPlaywrightReporter implements Reporter {
           console.warn(`[replay.io]: ${line}`);
         });
       }
+
+      // we need to output an extra line that is safe to be deleted
+      // Playwright's line reporter removes the last line here:
+      // https://github.com/microsoft/playwright/blob/0c11d6ed803db582a5508c70f89e55dc9a36c751/packages/playwright/src/reporters/line.ts#L91
+      //
+      // so if the user configured their reporters like this:
+      //
+      // reporters: [replayReporter({ upload: true }), ['line']]
+      //
+      // that can lead to removing *our* last log line
+      //
+      // the issue is tracked here: https://github.com/microsoft/playwright/issues/23875
+      console.log("[replay.io]:");
     } finally {
       await Promise.all([mixpanelAPI.close().catch(noop), logger.close().catch(noop)]);
     }