Skip to content

chore: remove siwe dependencies#3276

Merged
zoruka merged 5 commits intomainfrom
chore/remove-siwe-dependencies
Nov 19, 2024
Merged

chore: remove siwe dependencies#3276
zoruka merged 5 commits intomainfrom
chore/remove-siwe-dependencies

Conversation

@zoruka
Copy link
Contributor

@zoruka zoruka commented Nov 19, 2024

Description

This PR is removing SIWE dependencies and improving error message for SIWX sign request function.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 71f5454

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:44pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:44pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:44pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:44pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:44pm

@zoruka zoruka requested a review from tomiir November 19, 2024 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 335.15% 4822 / 23630
🔵 Statements 335.15% 4822 / 23630
🔵 Functions 368.54% 387 / 1430
🔵 Branches 474.44999999999993% 741 / 1721
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/utils/SIWXUtil.ts 5.31% 100% 0% 5.31% 17-18, 20-52, 54-130, 132-144, 146-155, 157-169, 171-258, 260-266
Generated in workflow #7461 for commit 71f5454 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants