Skip to content

chore: remove siwe dependencies #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoruka merged 5 commits into from
Nov 19, 2024
Merged

chore: remove siwe dependencies #3276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84ca47e
refactor: improve error on SIWXUTIL.requestSignMessage
zoruka Nov 19, 2024
fc4cc5d
chore: remove siwe dependency from other packages
zoruka Nov 19, 2024
edcbe61
chore: add changeset
zoruka Nov 19, 2024
e5096e5
Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…
zoruka Nov 19, 2024
71f5454
Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…
zoruka Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .changeset/afraid-points-tease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
'@reown/appkit-adapter-ethers5': patch
'@reown/appkit-adapter-ethers': patch
'@reown/appkit-adapter-solana': patch
'@reown/appkit-adapter-wagmi': patch
'@reown/appkit-scaffold-ui': patch
'@reown/appkit': patch
'@reown/appkit-core': patch
'@apps/demo': patch
'@apps/gallery': patch
'@apps/laboratory': patch
'@reown/appkit-adapter-polkadot': patch
'@reown/appkit-utils': patch
'@reown/appkit-cdn': patch
'@reown/appkit-common': patch
'@reown/appkit-experimental': patch
'@reown/appkit-polyfills': patch
'@reown/appkit-siwe': patch
'@reown/appkit-siwx': patch
'@reown/appkit-ui': patch
'@reown/appkit-wallet': patch
---

Removes @reown/appkit-siwe dependency from other packages and improve error message for SIWX request signature function
1 change: 0 additions & 1 deletion packages/adapters/ethers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@reown/appkit-polyfills": "workspace:*",
"@reown/appkit-scaffold-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
"@walletconnect/utils": "2.17.0",
Expand Down
1 change: 0 additions & 1 deletion packages/adapters/ethers5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@reown/appkit-polyfills": "workspace:*",
"@reown/appkit-scaffold-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
"@walletconnect/utils": "2.17.0",
Expand Down
1 change: 0 additions & 1 deletion packages/adapters/solana/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"@reown/appkit-polyfills": "workspace:*",
"@reown/appkit-scaffold-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
"valtio": "1.11.2"
Expand Down
1 change: 0 additions & 1 deletion packages/adapters/wagmi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@reown/appkit-polyfills": "workspace:*",
"@reown/appkit-scaffold-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
"@walletconnect/utils": "2.17.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/appkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
"@reown/appkit-core": "workspace:*",
"@reown/appkit-polyfills": "workspace:*",
"@reown/appkit-scaffold-ui": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
Expand All @@ -113,6 +112,7 @@
"viem": "2.x"
},
"devDependencies": {
"@reown/appkit-siwe": "workspace:*",
"@types/react": "18.3.1",
"@types/react-dom": "18.3.1",
"@vitest/coverage-v8": "2.1.3",
Expand Down
14 changes: 13 additions & 1 deletion packages/core/src/utils/SIWXUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,22 @@ export const SIWXUtil = {
const network = ChainController.getActiveCaipNetwork()
const client = ConnectionController._getClient()

if (!(siwx && address && network && client)) {
if (!siwx) {
throw new Error('SIWX is not enabled')
}

if (!address) {
throw new Error('No ActiveCaipAddress found')
}

if (!network) {
throw new Error('No ActiveCaipNetwork or client found')
}

if (!client) {
throw new Error('No ConnectionController client found')
}

try {
const siwxMessage = await siwx.createMessage({
chainId: network.caipNetworkId,
Expand Down
1 change: 0 additions & 1 deletion packages/scaffold-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"dependencies": {
"@reown/appkit-common": "workspace:*",
"@reown/appkit-core": "workspace:*",
"@reown/appkit-siwe": "workspace:*",
"@reown/appkit-ui": "workspace:*",
"@reown/appkit-utils": "workspace:*",
"@reown/appkit-wallet": "workspace:*",
Expand Down
1,535 changes: 981 additions & 554 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.