feat(remix-server-runtime): use type-fest's Jsonify type in Serialize

[MichaelDeBoey]

• Extracted Jsonify so that it's easier to switch to type-fest at a later stage
• Added cases for positive/negative infinity, Boolean, Number, String, Map & Set
• Added more deep grained type for objects that have a toJSON function
• Update UndefinedToOptional type
• Renamed some generics so they're more in line with the type-fest codebase
  • NonJsonPrimitive -> NotJsonable
    • Also replaced Function with (...arguments_: any[]) => any
  • SerializeTuple -> JsonifyList
    • Also updated this
  • SerializeObject -> JsonifyObject
    • Also updated this

This is mainly taking over @sachinraja's awesome work from sindresorhus/type-fest#519, thanks for that! 🙏

[changeset-bot]

⚠️ No Changeset found

Latest commit: aa5a23e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pcattori]

@MichaelDeBoey given that we have abandoned pretty types (at least for now), I think we are set to adopt type-fest types for JSON serialization, so happy to review if you updated this PR!

[MichaelDeBoey]

@pcattori I also applied all the changes from this repo into type-fest, but that does seem to break a test case ( see sindresorhus/type-fest#638)
Any idea what would be the fix?

I'd love to get it fixed upstream & here

[pcattori]

@MichaelDeBoey left a fix for the upstream type-fest PR

[MichaelDeBoey]

@pcattori I've updated this PR to the latest version of what I've done in sindresorhus/type-fest#638 as well

[pcattori]

@MichaelDeBoey I think the goal for this PR should be to replace our types with type-fest entirely after the upstream PR lands, rather than just update our types to match theirs.

[MichaelDeBoey]

@pcattori Unfortunately that's not possible (yet) as type-fest requires Node@>=14.16, which would be a breaking change as all our packages currently require Node@>=14.0.0
In v2, we can use type-fest as our minimum Node requirement would be 18

type-fest also requires Typescript@>=4.7
As we're currently not explicit about which versions we support, I don't think this is a problem though

[MichaelDeBoey]

@pcattori It seems like there's still a problem with the Jsonify type 🤔
sindresorhus/type-fest#638 (comment)

[pcattori]

@MichaelDeBoey since dev branch is now for v2 development and requires Node >=18 and TS >= 5.1, can we now switch this to just pull in the types from type-fest?

[MichaelDeBoey]

@pcattori I now changed this PR to use type-fest

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[smeijer]

Would it make sense to revert this PR till there is a stable solution? The Jsonify thing seems to be a serious issue. A lot of loaders now return Jsonify({}), while they were fully typed in Remix v1.9.x.

FYI, I'm typing my loaders using the DataFunctionArgs type, like:

export async function loader({  }: DataFunctionArgs) {
  return defer({ obj });
}

Just applied a patch-package, and all my trouble are gone

https://gist.github.com/smeijer/885310fca21828272bca29097f490534