fix(Jsonify): fix JsonifyTuple

[MichaelDeBoey]

As pointed out by @mattcorner in remix-run/remix#6566, this would otherwise Jsonify string[] & ["Some value"] to

{
    [x: number]: "Some value";
    length: "Some value";
    toString: null;
    toLocaleString: null;
    pop: null;
    push: null;
    concat: null;
    join: null;
    reverse: null;
    shift: null;
    slice: null;
    sort: null;
    splice: null;
    ... 20 more ...;
    0: "Some value";
}

Taken from @pcattori's solution in remix-run/remix#6616

[sindresorhus]

Tests are failing

[MichaelDeBoey]

@sindresorhus All tests are passing again

[WikiRik]

This change resulted in the following error when checking on TypeScript 4.8 for sequelize; TS2589: Type instantiation is excessively deep and possibly infinite.
See PR sequelize/sequelize#16252

[ghost]

We're seeing the same:

node_modules/type-fest/source/jsonify.d.ts:22:19 - error TS2589: Type instantiation is excessively deep and possibly infinite.
22  ? FilterNonNever<[Jsonify<F>, ...JsonifyList<R>]>

[sindresorhus]

@colincollerlever What TypeScript version?

[sindresorhus]

@MichaelDeBoey @pcattori Any ideas?

[pcattori]

Haven't looked into it, but current understanding is that its a TS 4.8 bug/limitation. Right now the options I see are:

• a) Drop support for TS 4.7 and 4.8
• b) Revert this PR and accept incorrect output types for input types like string{} & ["some value"]

[MichaelDeBoey]

Since both are bugs, I would say:

• revert this PR (b) and do a patch release
• Drop support for 4.7 & 4.8 (a)
• Add this PR again to fix the bug
• Do a major release

[sindresorhus]

I agree.

• https://github.com/sindresorhus/type-fest/releases/tag/v3.13.1
• https://github.com/sindresorhus/type-fest/releases/tag/v4.0.0