-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore(ci/no-response): Don't automatically mark issues/PRs as stale #6251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's leave that to the team discretion. Workflow will only close stale issues after 10 days
|
|
we can probably just revert #6082 (and related prs for other repos) |
|
@mcansh fine by me! |
|
Closed in favor of #6254 |
|
Reverting all these PRs will bring back the original problem that I was trying to fix by updating all these workflows though:
|
|
@MichaelDeBoey as I see it, the workflow is the following: 1 - Someone posts an issue / PR In step 3, OP do gets a notification when we comment requesting for more information, so no surprises here. What am I missing ? 🤔 |
|
What was in place before the reversal 2.1 - Nothing happens, then the bot says "This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈." This didn't make sense to me: OP opened an issue, nothing happened, so it will get closed after a while? |
|
@machour The concern why I originally update the workflow was because we did ask for changes (and added the If there would have been a notice/reminder, the author would have been able to finish all the requested updates & we could have merged the PR. If it took the author too long after the notice/reminder, I would be fine with closing the PR |
|
@MichaelDeBoey in the linked PR, I'm seeing that the workflow was the one adding the "needs-response" on its own. Bot should only close issues labeled "needs-response" by a human, if there was indeed no response from the author after a while. The examples workflow was simply missing: |
Discussed with @ryanflorence on Discord.
Let's leave that to the team discretion.
Workflow will only close stale issues after 10 days