Skip to content

Conversation

@machour
Copy link
Contributor

@machour machour commented Apr 30, 2023

Discussed with @ryanflorence on Discord.

Let's leave that to the team discretion.
Workflow will only close stale issues after 10 days

Let's leave that to the team discretion. Workflow will only close stale issues after 10 days
@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2023

⚠️ No Changeset found

Latest commit: 0e44a33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@machour machour requested review from MichaelDeBoey and mcansh and removed request for mcansh April 30, 2023 13:26
@mcansh
Copy link
Contributor

mcansh commented Apr 30, 2023

we can probably just revert #6082 (and related prs for other repos)

@machour
Copy link
Contributor Author

machour commented Apr 30, 2023

@mcansh fine by me!

@machour
Copy link
Contributor Author

machour commented Apr 30, 2023

Closed in favor of #6254

@machour machour closed this Apr 30, 2023
@machour machour deleted the no-automatic-stale branch April 30, 2023 18:38
@MichaelDeBoey
Copy link
Member

Reverting all these PRs will bring back the original problem that I was trying to fix by updating all these workflows though:

This will notify people before the issue/PR is actually closed as it now often happens by surprise when people are assuming everything is already fine

@machour
Copy link
Contributor Author

machour commented Apr 30, 2023

@MichaelDeBoey as I see it, the workflow is the following:

1 - Someone posts an issue / PR
2 - If no one from the team attend to it, it stays open indefinitely
3 - If someone from the team asks a follow up question, we add a needs-response label manually
4 - If OP answers, the label gets removed, back to step 1
5 - If no feedback is received, the bot closes the issue/PR.

In step 3, OP do gets a notification when we comment requesting for more information, so no surprises here.

What am I missing ? 🤔

@machour
Copy link
Contributor Author

machour commented Apr 30, 2023

What was in place before the reversal

2.1 - Nothing happens, then the bot says "This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈."

This didn't make sense to me: OP opened an issue, nothing happened, so it will get closed after a while?

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Apr 30, 2023

@machour The concern why I originally update the workflow was because we did ask for changes (and added the needs-response label) in remix-run/examples#52, the author updated some things, but did not all of the asked changes.
The author was planning on doing so, but forgot about it.
After a while, the PR was closed automatically.

If there would have been a notice/reminder, the author would have been able to finish all the requested updates & we could have merged the PR.

If it took the author too long after the notice/reminder, I would be fine with closing the PR

@machour
Copy link
Contributor Author

machour commented Apr 30, 2023

@MichaelDeBoey in the linked PR, I'm seeing that the workflow was the one adding the "needs-response" on its own.
This is clearly wrong. Only humans should add that label when requesting a change or asking a question.

Bot should only close issues labeled "needs-response" by a human, if there was indeed no response from the author after a while. The examples workflow was simply missing: days-before-stale: -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants