feat(firebase): add Google Account auth #52

penx · 2022-10-31T12:54:42Z

Reopening #4, remix-run/remix#4057 against remix-run/examples

Firebase example - Integration with Google Sign-in Provider

Closes: "sign-in with Google" suggestion at remix-run/remix#1811 (comment)

Adds a "Login with Google" link:

...that takes a user to the Google's auth screen:

...and then creates an account (if it doesn't yet exist) and signs them in:

github-actions · 2023-01-20T13:10:57Z

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you want to resume the work on this PR! 🙂

penx · 2023-01-20T13:13:34Z

@machour @mcansh @MichaelDeBoey

happy to abandon this if it's not wanted, but I've opened this PR 3 times now (#52, #4, remix-run/remix#4057), and rebased several times on request, now github actions is telling me you're waiting for a response from me 😄

MichaelDeBoey

@penx Please rebase this branch onto latest main & resolve conflicts and remarks

firebase/app/routes/auth/google.tsx

Ported from remix-run/remix@e6022d2 fix yarn lock on main

Co-authored-by: Michaël De Boey <[email protected]>

penx · 2023-01-25T16:43:20Z

@MichaelDeBoey rebased and confirmed it's all still working. Also addressed feedback and updated the docs a little.

firebase/README.md

firebase/app/routes/login.tsx

firebase/app/routes/auth/google.tsx

firebase/app/routes/login.tsx

firebase/README.md

Co-authored-by: Michaël De Boey <[email protected]>

github-actions · 2023-04-16T18:08:07Z

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you want to resume the work on this PR! 🙂

penx · 2023-04-16T18:11:32Z

@MichaelDeBoey not sure why this was closed. Are you waiting for something from?

penx · 2023-04-16T18:23:23Z

Actually maybe it’s the hard coded localhost, had forgotten this needed addressing

MichaelDeBoey · 2023-04-16T19:09:30Z

@penx This was indeed waiting for the hardcoded localhost I think

I'll re-open as I know we'll see the update in a timely manner. 😉

I'll also update the no-response workflow to give a notice before actually closing the PRs 👍

penx · 2023-05-03T10:49:44Z

I have removed the 2 hard coded "localhost", and calculate redirectUri instead

MichaelDeBoey

Some small remarks

MichaelDeBoey · 2023-05-06T22:23:33Z

firebase/README.md


 ## Deploying

 1. Follow the "Run against a Firebase Project" steps above if not done already


Suggested change

1. Follow the "Run against a Firebase Project" steps above if not done already

1. Follow the "Run against a Firebase project" steps above if not done already

MichaelDeBoey · 2023-05-06T22:23:54Z

firebase/README.md

+
+## Integration with Google Sign-in Provider
+
+The "Login with Google" link will only work when running against a Firebase Project.


Suggested change

The "Login with Google" link will only work when running against a Firebase Project.

The "Login with Google" link will only work when running against a Firebase project.

MichaelDeBoey · 2023-05-06T22:24:05Z

firebase/README.md

+
+The "Login with Google" link will only work when running against a Firebase Project.
+
+After the steps in "Run against a Firebase Project" have been completed:


Suggested change

After the steps in "Run against a Firebase Project" have been completed:

After the steps in "Run against a Firebase project" have been completed:

MichaelDeBoey · 2023-05-06T22:24:32Z

firebase/README.md

+
+After the steps in "Run against a Firebase Project" have been completed:
+
+- In the [Firebase Console](https://console.firebase.google.com), navigate to Authentication > Sign-in method > Add new provider > Google. Make a note of the client ID and secret and add them to the .env file as GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET.


Suggested change

- In the [Firebase Console](https://console.firebase.google.com), navigate to Authentication > Sign-in method > Add new provider > Google. Make a note of the client ID and secret and add them to the .env file as GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET.

- In the [Firebase Console](https://console.firebase.google.com), navigate to Authentication > Sign-in method > Add new provider > Google. Make a note of the client ID and secret and add them to the `.env` file as `GOOGLE_CLIENT_ID` and `GOOGLE_CLIENT_SECRET`.

MichaelDeBoey · 2023-05-06T22:26:05Z

firebase/app/firebase-rest.ts

+  }
+) => {
+  const body = {
+    postBody: "id_token=" + idToken + "&providerId=" + providerId,


Suggested change

postBody: "id_token=" + idToken + "&providerId=" + providerId,

postBody: `id_token=${idToken}&providerId=${providerId}`,

MichaelDeBoey · 2023-05-06T22:26:47Z

firebase/app/firebase-rest.ts

+) => {
+  const body = {
+    postBody: "id_token=" + idToken + "&providerId=" + providerId,
+    requestUri: "http://localhost",


@penx Should this stay localhost? 🤔

MichaelDeBoey · 2023-05-06T22:29:03Z

firebase/app/routes/login.tsx

  Link,
  useActionData,
  useLoaderData,
+  useLocation,


Suggested change

useLocation,

github-actions · 2023-05-27T23:07:43Z

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you want to resume the work on this PR! 🙂

penx mentioned this pull request Oct 31, 2022

feat(firebase): add Google Account auth #4

Closed

github-actions bot added the needs-response We need a response from the original author about this issue/PR label Dec 30, 2022

github-actions bot closed this Jan 20, 2023

penx mentioned this pull request Jan 20, 2023

feat(firebase): deploy to Cloud Functions for Firebase #53

Merged

2 tasks

MichaelDeBoey reopened this Jan 20, 2023

MichaelDeBoey requested changes Jan 20, 2023

View reviewed changes

firebase/app/routes/auth/google.tsx Outdated Show resolved Hide resolved

firebase/app/routes/auth/google.tsx Outdated Show resolved Hide resolved

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Jan 20, 2023

feat(examples/firebase): google account auth

d2f7e3e

Ported from remix-run/remix@e6022d2 fix yarn lock on main

penx force-pushed the firebase-auth-provider branch from ed593f3 to d2f7e3e Compare January 25, 2023 15:36

penx marked this pull request as draft January 25, 2023 15:36

Docs update

76c1167

penx marked this pull request as ready for review January 25, 2023 16:41

Apply suggestions from code review

12f85cc

Co-authored-by: Michaël De Boey <[email protected]>

penx requested a review from MichaelDeBoey January 25, 2023 16:42

penx commented Jan 25, 2023

View reviewed changes

firebase/README.md Outdated Show resolved Hide resolved

Update firebase/README.md

d9f868b

penx commented Jan 25, 2023

View reviewed changes

firebase/app/routes/login.tsx Show resolved Hide resolved

penx commented Jan 25, 2023

View reviewed changes

firebase/app/routes/auth/google.tsx Outdated Show resolved Hide resolved

penx marked this pull request as draft January 25, 2023 16:50

penx commented Jan 25, 2023

View reviewed changes

firebase/app/routes/login.tsx Outdated Show resolved Hide resolved

MichaelDeBoey requested changes Jan 25, 2023

View reviewed changes

Apply suggestions from code review

ad340eb

Co-authored-by: Michaël De Boey <[email protected]>

github-actions bot added the needs-response We need a response from the original author about this issue/PR label Mar 26, 2023

github-actions bot closed this Apr 16, 2023

MichaelDeBoey reopened this Apr 16, 2023

MichaelDeBoey mentioned this pull request Apr 16, 2023

chore: update no-response workflow #217

Merged

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Apr 16, 2023

MichaelDeBoey mentioned this pull request Apr 30, 2023

chore(ci/no-response): Don't automatically mark issues/PRs as stale remix-run/remix#6251

Closed

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 1, 2023

penx and others added 2 commits May 3, 2023 11:47

Remove hard coded localhost, calculate redirectUri

837ec09

Merge branch 'main' into firebase-auth-provider

bb65602

penx marked this pull request as ready for review May 3, 2023 10:47

penx requested a review from MichaelDeBoey May 3, 2023 10:47

github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 3, 2023

MichaelDeBoey requested changes May 6, 2023

View reviewed changes

MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 6, 2023

github-actions bot closed this May 27, 2023


		## Deploying

		1. Follow the "Run against a Firebase Project" steps above if not done already


		## Integration with Google Sign-in Provider

		The "Login with Google" link will only work when running against a Firebase Project.


		The "Login with Google" link will only work when running against a Firebase Project.

		After the steps in "Run against a Firebase Project" have been completed:


		After the steps in "Run against a Firebase Project" have been completed:

		- In the [Firebase Console](https://console.firebase.google.com), navigate to Authentication > Sign-in method > Add new provider > Google. Make a note of the client ID and secret and add them to the .env file as GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET.

	postBody: "id_token=" + idToken + "&providerId=" + providerId,
	postBody: `id_token=${idToken}&providerId=${providerId}`,

feat(firebase): add Google Account auth #52

feat(firebase): add Google Account auth #52

Uh oh!

Conversation

penx commented Oct 31, 2022

Uh oh!

github-actions bot commented Jan 20, 2023

Uh oh!

penx commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelDeBoey left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

penx commented Jan 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2023

Uh oh!

penx commented Apr 16, 2023

Uh oh!

penx commented Apr 16, 2023

Uh oh!

MichaelDeBoey commented Apr 16, 2023

Uh oh!

penx commented May 3, 2023

Uh oh!

MichaelDeBoey left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey May 6, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

penx commented Jan 20, 2023 •

edited

Loading

MichaelDeBoey left a comment •

edited

Loading