Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(deno): fix V2_MetaFunction import #6111

Closed
wants to merge 1 commit into from

Conversation

markdalgleish
Copy link
Member

This template depends on @remix-run/deno, not @remix-run/node. Noticed this while adding the css-bundle boilerplate.

@markdalgleish markdalgleish requested a review from mcansh April 20, 2023 01:38
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

⚠️ No Changeset found

Latest commit: e6b6053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title fix node package usage in deno template templates(deno): fix V2_MetaFunction import Apr 20, 2023
@mcansh
Copy link
Collaborator

mcansh commented Apr 20, 2023

per #5785, we should be importing from the react package for the most accurate types (has matches and is used for rendering), which is what's being done on the main branch

@MichaelDeBoey
Copy link
Member

@mcansh This was reverted in @pcattori's #6123

@markdalgleish
Copy link
Member Author

Closing this since it's already been handled in main.

@markdalgleish markdalgleish deleted the markdalgleish/fix-deno-template branch April 21, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants