-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗺 API updates for v2 meta
arguments and types
#5785
Conversation
|
Name | Type |
---|---|
@remix-run/cloudflare | Minor |
@remix-run/deno | Minor |
@remix-run/node | Minor |
@remix-run/react | Minor |
@remix-run/server-runtime | Minor |
@remix-run/cloudflare-pages | Minor |
@remix-run/cloudflare-workers | Minor |
@remix-run/architect | Minor |
@remix-run/express | Minor |
@remix-run/netlify | Minor |
@remix-run/testing | Minor |
@remix-run/vercel | Minor |
@remix-run/dev | Minor |
@remix-run/serve | Minor |
create-remix | Minor |
@remix-run/css-bundle | Minor |
remix | Minor |
@remix-run/eslint-config | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some questions, nothing blocking though.
🤖 Hello there, We just published version Thanks! |
meta
arguments and typesmeta
arguments and types
This PR does a few things we'll want to include behind the
v2_meta
flag before the major release.V2_HtmlMetaDescriptor
has been renamed toV2_MetaDescriptor
. This is shorter but also more aligned with thelinks
function return value type, which isLinkDescriptor
. It also makes a bit more sense as we support values for other HTML tags than<meta>
.V2_HtmlMetaDescriptor
andV2_HtmlMetaFunction
types should be imported from@remix-run/react
instead of@remix-run/<runtime>
since A) the primary responsibility ofmeta
is rendering, and B)matches
data only makes sense in the context of an app callinguseMatches
. I think we should follow suit here withLinksFunction
in v2, but that's for a separate PR.meta
function's arguments have been simplifiedparentsData
has been removed, as each route's loader data is available on thedata
property of its respectivematch
objectroute
property on route matches has been removed, as relevant match data is attached directly to the match object