Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-dev): remove jsxDev compiler option #4358

Closed
wants to merge 4 commits into from
Closed

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Oct 12, 2022

it causes import_jsx_dev_runtime.jsxDEV is not a function errors when building prior to dev mode

Closes #4081
Closes #5743

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: 91aa5a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh marked this pull request as ready for review October 12, 2022 19:34
@MichaelDeBoey MichaelDeBoey changed the title chore(remix-dev): remove jsxDev compiler option chore(remix-dev): remove jsxDev compiler option Oct 27, 2022
it causes `import_jsx_dev_runtime.jsxDEV is not a function` errors when building prior to dev mode
@kyeotic
Copy link

kyeotic commented Mar 18, 2023

Is this still planned @mcansh

@sajidmasoodbscs
Copy link

Is this still planned @mcansh? I'm facing still the same issue "import_jsx_dev_runtime.jsxDEV is not a function" on local when try to start with npm start, but when use "npm run dev" error not produced.

@brophdawg11
Copy link
Contributor

@pcattori Is this still relevant in the new dev server?

@pcattori
Copy link
Contributor

pcattori commented Aug 4, 2023

This error is caused when a Remix app is built in dev mode and subsequently started by an app server running in production:

# 1. build app in dev mode
NODE_ENV=development remix build # either like this,
remix dev # or like this

# 2. later, without rebuilding for prod, run the app with a production-mode app server
NODE_ENV=production remix-serve # either like this,
NODE_ENV=production node ./server.js # or like this

In CI/CD, your app should be getting built and run in production-mode only and shouldn't be a problem.

For local dev, the solution is to infer the mode from the built Remix server, which is solved by #6964, making this PR obsolete.

@pcattori pcattori closed this Aug 4, 2023
@pcattori pcattori deleted the logan/jsxdev branch August 4, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Closed
6 participants