-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import_jsx_dev_runtime.jsxDEV is not a function after upgrade to 1.7.0 in Docker Container #4081
Comments
I came across this issue today while updating |
i haven’t seen this in any of my testing thus far, i might be able to take a look tomorrow, but for sure on Monday. |
i can't reproduce :( https://github.com/mcansh/simple-docker-test you could try nuking |
edit: oh duh semver ranges 🤦 - i think that may be the root of the issue. edit 2: actually is this happening just locally or also when you deploy? Make sure you have a |
I was able to do it locally, as in |
Not sure why, but this reproduces handily on a stock blues stack while running Repro steps are:
(seems to repro on node v16 as well) |
We're getting a similar error with import { RemixServer } from '@remix-run/react';
console.log(RemixServer) //=> undefined In 1.6.8, This is the error we're getting:
|
The cause of the problem has been found: #4080 (comment) |
@FlatMapIO the problem does not seem to be precisely the same. I tried all those solutions and they don't seem to work. |
yep, |
Hmm weird I'm sure I upgraded couple of days ago and just now ran into this issue 🤨 Downgrading to 1.6.8 seems to have solved it for now |
Odd. I also ran into this today when starting up my local dev server for the first time in a few days. Been on 1.7.0 for a while now, though. So not sure what's changed. Edit:
|
Just tried a clean build, with a clean package manager and docker cache. The problem is still there for me. |
is your repo public? or can you try to reproduce on a fresh |
Uh to clarify to me it happened running dev on my machine, so no Docker required 😅 But since last time it didn't happen again 🤷🏻♂️ |
This only happens with |
public repo reproduction steps are here #4081 (comment) (as mentioned, doesn't repro on 1.6.8) |
I'm having a similar problem, getting an error However, I am having a really hard time reproducing it on a minimal repro. Also, tried clearing out node_modules, cache, build, etc.. My app works fine on 1.6.8, not on 1.7.0. yarn dev |
I'm getting it when deploying to fly.io. Local dev appears to be working fine, as soon as I deployed it app stopped loading and this is in the logs:
|
Ran into the same issue. Runs without issues locally, but then end up seeing the |
This is blocking us from upgrading our production apps as well; runs fine on local machines but the production builds running in containers are all encountering this on >1.7.0. Happens both the default express-based Remix App Server and deno runtimes. |
Same thing here. I'm able to reproduce it running |
@dusty @wladiston both of your issues are an upstream issue with esbuild (which has since been fixed in 0.15.8) evanw/esbuild#2534 - i'll be looking into upgrading our dependency next week |
Thanks for the followup @mcansh . We recently tried out 1.7.2 while moving all the keys above spreads and all is well for us. |
Thanks @mcansh. Using an |
Adding
|
We managed to fix the issue by forcing esbuild to ^0.15.8 (resolutions field in package.json). Now running remix 1.7.2. |
Seeing the same thing in 1.7.6 Solved by rm -rf build folder and then running the build script again. |
Hi! |
I got the same |
I don't know if it is helpful, but I experienced the same error and solved it in this mode:
Version:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Is there a good reason why
Asking because I have/had reasons, and then things just stopped working once I upgraded from version |
I'm getting this error now after upgrading to 1.12.0. No docker, this is macos dev env. Upgraded and setup to run new dev env with concurrent TW, remix dev & nodemon:
Everything builds, but I get this same error of
Only way I can actually get project to render without error now is to run:
This at least allows me to still view the project. I've tried
The error still occurs. Essentially I can no longer use |
For what it's worth, I'm using 1.13.0 and I ran into this issue when I was explicitly setting
Changing "development" to "production" and everything works as expected. |
remix 1.9.0 I may encounter this problem accidentally. Here is my solution (temporary)
My other servers have never had such problems (upload the build file can run), but this server can't. here is my package.json
|
For me this issue happened after uninstall some packages. |
It was happening in my case because I had the wrong value in the |
I'm running into this as well, but can recreate it without docker as long as I run with ``NODE_ENV=production node server.js`. However, if I build with
Either way, it seems building for production is still broken. Seems like the PR fix has stalled. |
I'm getting the same error when I deploy it to fly.io and visit the deployed app. Happens on a fresh remix install and deploy of this PWA remix stack - https://github.com/ShafSpecs/rockspec-stack
|
@lukaszdz i noticed you have a |
helped to fix ! |
`NODE_ENV=production` is required due remix issue remix-run/remix#4081 Once that issue is solved, we should be able to remove the NODE_ENV setting from here.
this happens out-of-the box with the following steps:
opening browser shows the following: server logTypeError: (0 , import_jsx_dev_runtime.jsxDEV) is not a function
at /Users/jenna/Development/remix-netlify/app/entry.server.tsx:89:7
at new Promise (<anonymous>)
at handleBrowserRequest (/Users/jenna/Development/remix-netlify/app/entry.server.tsx:87:10)
at handleRequest (/Users/jenna/Development/remix-netlify/app/entry.server.tsx:31:7)
at handleDocumentRequestRR (/Users/jenna/Development/remix-netlify/node_modules/@remix-run/server-runtime/dist/server.js:215:20)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at requestHandler (/Users/jenna/Development/remix-netlify/node_modules/@remix-run/server-runtime/dist/server.js:49:18)
at Object.<anonymous> (/Users/jenna/Development/remix-netlify/node_modules/@remix-run/netlify/dist/server.js:35:20)
Response with status 500 in 5 ms. |
This is a pretty real problem. I created a brand new remix app, just the basics, served by Remix App Server and using typescript.
Edit: Looks like I missed some instructions to run |
I was able to fix this issue by changing the node version to >16 in package.json.
|
#6964 solves this from happening |
Hey all, I'm just trying to dockerize a new remix project and running into this exact issue. I've read everything briefly, but what must I do to dockerize my remix app? Is the only option to downgrade everything to 1.6.8/1.7?
|
@yehudamakarov is this locally or on some CI? if locally, try adding |
|
What version of Remix are you using?
1.7.0
Steps to Reproduce
After upgrading to 1.7.0 and building my docker container, Going to any page yields
import_jsx_dev_runtime.jsxDEV is not a function
on the server, and an error page is rendered.Here is my Docker file that causes it to fail:
It is only failing in the container, running the app even with remix-serve works correctly. All package.json dependencies are locked in.
Expected Behavior
The app should work as it did before the upgrade to 1.7.0 (Release notes said no changes to code necessary).
Actual Behavior
The app fails to render any pages.
The text was updated successfully, but these errors were encountered: