Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump esbuild to latest, remove shim #3860

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jul 28, 2022

[email protected] - "Add support for React 17's automatic JSX transform"

Signed-off-by: Logan McAnsh [email protected]

Closes: #

  • Docs
  • Tests

Testing Strategy:

all of our existing tests should cover the new behavior, but maybe we add one for a package that we know caused problems

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

🦋 Changeset detected

Latest commit: eee8458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/eslint-config Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/node Patch
@remix-run/deno Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh force-pushed the logan/bump-esbuild-auto-jsx-transform branch from 9fe3caa to a72454b Compare July 28, 2022 20:48
@mcansh mcansh marked this pull request as ready for review July 28, 2022 20:55
@jacob-ebey
Copy link
Member

jacob-ebey commented Jul 28, 2022

Let's add in https://esbuild.github.io/api/#jsx-dev as well and toggle it based on the options.mode.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

.changeset/gold-mice-pretend.md Outdated Show resolved Hide resolved
@mcansh
Copy link
Collaborator Author

mcansh commented Jul 29, 2022

published an experimental to make sure all is well 0.0.0-experimental-ea38b6458

@MichaelDeBoey MichaelDeBoey force-pushed the logan/bump-esbuild-auto-jsx-transform branch from ea38b64 to 11d7d72 Compare August 3, 2022 09:52
@mcansh mcansh requested a review from chaance August 3, 2022 18:52
@MichaelDeBoey MichaelDeBoey force-pushed the logan/bump-esbuild-auto-jsx-transform branch from 368752f to 9483441 Compare August 4, 2022 11:39
@mcansh mcansh removed the request for review from chaance August 8, 2022 15:07
@MichaelDeBoey MichaelDeBoey force-pushed the logan/bump-esbuild-auto-jsx-transform branch from 81ff481 to 876a6b3 Compare August 13, 2022 14:07
@chaance chaance merged commit cf1f2d8 into dev Aug 24, 2022
@chaance chaance deleted the logan/bump-esbuild-auto-jsx-transform branch August 24, 2022 16:16
@MichaelDeBoey MichaelDeBoey added the awaiting release This issue has been fixed and will be released soon label Aug 24, 2022
@MichaelDeBoey MichaelDeBoey removed the awaiting release This issue has been fixed and will be released soon label Aug 25, 2022
@mcansh mcansh added awaiting release This issue has been fixed and will be released soon and removed awaiting release This issue has been fixed and will be released soon labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifier 'React' has already been declared with multiple external libraries
8 participants