-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix(react-router): add crossOrigin prop to Links component #14687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router): add crossOrigin prop to Links component #14687
Conversation
🦋 Changeset detectedLatest commit: c6d079d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Description
When using a CDN with CORS headers, CSS files loaded via the
<Links>component can fail due to browser cache behavior.After #14463, React Router appends
#suffix to CSS hrefs for dynamic imports. This causes Vite to make a separate request (since URLs differ), but both requests share the browser cache. If React Router's<link>lackscrossOriginwhile Vite's hascrossOrigin="anonymous", the cached response (without CORS headers) fails Vite's CORS check.Changes
crossOriginprop toLinksPropsinterfacecrossOriginto<link>elements inLinkscomponentImpact
Fixes #14678