fix: retain CSS for dynamic imports on navigation #14463
Merged
+359
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de3b900 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
added
the
alpha-release
|
Alpha release created:
git log --pretty=oneline [email protected] |
github-actions
bot
removed
the
alpha-release
This was referenced Oct 22, 2025
markdalgleish
commented
Oct 22, 2025
Comment on lines
+398
to
+413
| .map((href) => { | ||
| let publicHref = `${ctx.publicPath}${href}`; | ||
| // If this CSS file is also dynamically imported anywhere in the | ||
| // application, we append a hash to the href so Vite ignores it when | ||
| // managing dynamic CSS injection. If we don't do this, Vite's | ||
| // dynamic import logic might hold off on inserting a new `link` | ||
| // element because it's already in the page, only for React Router | ||
| // to remove it when navigating to a new route, resulting in missing | ||
| // styles. By appending a hash, Vite doesn't detect that the CSS is | ||
| // already in the page and always manages its own `link` element. | ||
| // This means that Vite's CSS stays in the page even if the | ||
| // route-level CSS is removed from the document. We use a hash here | ||
| // because it's a unique `href` value but isn't a unique network | ||
| // request and only adds a single character. | ||
| return allDynamicCssFiles.has(href) ? `${publicHref}#` : publicHref; | ||
| }), |
There was a problem hiding this comment.
This is the core of the fix. The rest of the code is in service of this workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.