-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix(react-router/rsc): remove dependency on @types/node in TypeScript declaration files
#14059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router/rsc): remove dependency on @types/node in TypeScript declaration files
#14059
Conversation
|
Hi @Methuselah96, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
🦋 Changeset detectedLatest commit: 007f003 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
markdalgleish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Can you please update this PR to point to the dev branch?
@types/node
ae7d776 to
7e64b28
Compare
|
Done, sorry for missing that |
@types/node@types/node in TypeScript declaration files
|
@markdalgleish Any estimate on when this will be released? |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Fixes #14042 by removing the declaration of the
___reactRouterServerStorage___variable from the global scope in the TypeScript declaration files. If it's desirable for this to exist in the declaration file, then I can explore other options, but it seems like somewhat of a private variable that doesn't need to be in the declaration files.