Skip to content

fix(react-router/rsc): remove dependency on @types/node in TypeScript declaration files #14059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025
Merged

fix(react-router/rsc): remove dependency on @types/node in TypeScript declaration files #14059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdc77a2
fix: remove dependency on @types/node in declaration files
Methuselah96 Jul 23, 2025
a395cfa
CLA
Methuselah96 Jul 23, 2025
b00d6bf
Create shiny-owls-glow.md
Methuselah96 Jul 23, 2025
7e64b28
Update changeset
markdalgleish Jul 23, 2025
007f003
Update changeset
markdalgleish Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shiny-owls-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-router": patch
---

Remove dependency on `@types/node` in TypeScript declaration files
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@
- mcansh
- MeatSim
- MenouerBetty
- Methuselah96
- mfijas
- MichaelDeBoey
- michal-antczak
Expand Down
10 changes: 3 additions & 7 deletions packages/react-router/lib/rsc/server.rsc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,9 @@ type ServerContext = {
redirect?: Response;
};

declare global {
var ___reactRouterServerStorage___:
| AsyncLocalStorage<ServerContext>
| undefined;
}

const globalVar = typeof globalThis !== "undefined" ? globalThis : global;
const globalVar = (typeof globalThis !== "undefined" ? globalThis : global) as {
___reactRouterServerStorage___?: AsyncLocalStorage<ServerContext>;
};

const ServerStorage = (globalVar.___reactRouterServerStorage___ ??=
new AsyncLocalStorage<ServerContext>());
Expand Down