Patch patch cause the spec is weird #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec14142 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Mar 16, 2023
| @@ -5899,6 +5899,47 @@ describe("a router", () => { | |||
| expect((await request.formData()).get("query")).toBe("params"); | |||
| }); | |||
|
|
|||
| // https://fetch.spec.whatwg.org/#concept-method | |||
| it("properly handles method=PATCH weirdness", async () => { | |||
There was a problem hiding this comment.
This test doesn't fail (without the code fix) at the moment - I think our fetch polyfill is probably uppercasing all methods, so we should update that to force this test to be able to fail
There was a problem hiding this comment.
brophdawg11
commented
Mar 17, 2023
| e = _e; | ||
| } | ||
| expect(e).toMatchInlineSnapshot( | ||
| `[Error: query()/queryRoute() requests must contain an AbortController signal]` |
There was a problem hiding this comment.
We've since fixed our Request implementation to match the spec so it always has a signal. It's no longer possible to create one without a signal so altered these tests to just confirm that
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
toUpperCase()back that was removed in #10207 cause the spec is weird and doesn't uppercasepatch: https://fetch.spec.whatwg.org/#concept-methodRelies on remix-run/web-std-io#30 before the unit test would actually fail otherwise